feat: add custom_id support to upload_to_browserstack_app_live action#33
Open
alsedi wants to merge 1 commit into
Open
feat: add custom_id support to upload_to_browserstack_app_live action#33alsedi wants to merge 1 commit into
alsedi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
upload_to_browserstack_app_automateaccepts acustom_id, butupload_to_browserstack_app_livedoes not, even though the underlyingBrowserstackHelper.upload_fileand the/app-live/uploadendpoint support it.This PR brings the app_live action to parity with app_automate by passing
custom_idfrom params and toupload_fileMotivation
Without it, App Live uploads can only be addressed by the auto-generated
app_url, a stablecustom_idhelps reference a build by a constant identifier.Testing
bundle exec rspec: all green, including the new test for custom_id spec.